Mir

Code review comment for lp:~vanvugt/mir/Rectangle-contains-Rectangle

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

100 + EXPECT_FALSE(r.contains(Rectangle{{left,top}, {1,0}}));
104 + EXPECT_FALSE(r.contains(Rectangle{{left,top}, {1,0}}));

125 + EXPECT_FALSE(r.contains(Rectangle{{left,top}, {1,0}}));
129 + EXPECT_FALSE(r.contains(Rectangle{{left,top}, {1,0}}));

Is there a reason to recheck for these?

Having a unit test for the expected behavior of empty rectangles is, of course, desirable, but I think a comment in the code would be more helpful for users of the class.

review: Needs Fixing

« Back to merge proposal