Mir

Code review comment for lp:~vanvugt/mir/Rectangle-contains-Rectangle

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> I have no preference for the behaviour of empty rectangles. And I think we should leave the behaviour
> "officially undefined" until there's a good enough reason to define it.

Empty rectangles are not an edge case we can ignore, we need some form of support for them. We are implicitly defining the behavior, and code will eventually depend on it in some way, even if it's in the form of extra logic to avoid "undefined" behavior. So, UB gains us nothing really. We are better off defining the behavior and if we need to change it in the future, then so be it.

« Back to merge proposal