Mir

Code review comment for lp:~vanvugt/mir/GammaCurve

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

+typedef std::vector<uint16_t> GammaCurve;
...
- GammaCurves(std::vector<uint16_t> const& red,
- std::vector<uint16_t> const& green,
- std::vector<uint16_t> const& blue);
+ GammaCurves(GammaCurve const& red,
+ GammaCurve const& green,
+ GammaCurve const& blue);

One has to wonder if there are implicit constraints (like the three vectors having the same length) and if *all* the functionality of std::vector<> is appropriate to GammaCurve.

But this MP doesn't create those issues, it just fails to address them.

review: Abstain

« Back to merge proposal