Code review comment for lp:~vanvugt/compiz/fix-751605

Okay, lets go with this then.

I anticipate that it won't be that difficult to implement the
conditional maximize behaviour. All that needs to be done is to track
the window position and set the CompWindowActionMaximizeMask flag in
the window actions.

Might be more difficult to get under test though, but we should
probably make an exception for this.

On Thu, Nov 15, 2012 at 10:50 PM, John Lea <email address hidden> wrote:
> @smspillaz; yes the gesture preview displaying on the wrong monitor is annoying, but the main issues is that "the window should always maximise on the the monitor that contains the majority of the window at the moment the user gives the maximise command".
>
> Regarding the corner case of the minimum size (*not the current size*) of a window being larger than the available area when in the maximised state, I agree that a nice solution would be to prevent the user from trying to maximise the window in the first place. Yes having the 'maximise' window decoration disappear and reappear is a bit weird, but it is better than either the window maximising when their isn't enough space, or the user pressing the button and nothing happening. Given that this is a very rare corner case I am happy to go for "maximise button disappears when the minimum possible size of the window is larger than the available screen area when maximised" as a solution.
>
>
> --
> https://code.launchpad.net/~vanvugt/compiz/fix-751605/+merge/134404
> You are reviewing the proposed merge of lp:~vanvugt/compiz/fix-751605 into lp:compiz.

--
Sam Spilsbury