Code review comment for lp:~vanvugt/compiz/fix-751605

I quickly had a test of this branch and noticed that the jumpiness problem that used to be quite bad in older versions of the code is no longer a problem. So that's probably a good thing. Things can still get jumpy when you alt-drag, but it seems for now that its not possible to get into a situation where the window titlebar is not visible.

I also tested this branch with the chunk that removes the part of the code which considered other monitors in that case reverted and it works as expected when you have variable size windows and two monitors stacked one above the other. That was primarily what bug 751605 was about.

I think it might be good to get some design feedback as to exactly what to do in this case though. I suspect that the design team only intended the "maximize on the same monitor that the user asked for the maximize on" statement for the cases where it was actually possible to do so. I'm sure that the design team didn't intend for that to extend to cases where it would be impossible to do so - for example where maximizing the window would actually make it larger than the screen size and thus parts of the window were offscreen.

However, considering that the "jumping behaviour" is no longer the problem that it once was when I first fixed this problem, I'm happy for it to go either way.