Code review comment for lp:~vanvugt/compiz/fix-201681-wall

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Okay, lets put this through now.

On Thu, Nov 29, 2012 at 6:47 PM, Daniel van Vugt
<email address hidden> wrote:
> The only relevant tests would be: EXPECT_TRUE(1 != 10)
> or: EXPECT_TRUE(0 + screen->width() - 1 == screen->width () - 1)
>
> They're kind of pointless statements.
>
> That is unless we fix the whole mouse warping issue _everywhere_. That would be non-trivial and require tests.
> --
> https://code.launchpad.net/~vanvugt/compiz/fix-201681-wall/+merge/136879
> Your team Compiz Maintainers is requested to review the proposed merge of lp:~vanvugt/compiz/fix-201681-wall into lp:compiz.

--
Sam Spilsbury

« Back to merge proposal