lp:~vanvugt/compiz/fix-1097126

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.9 at revision 3549

Daniel d'Andrada (community): Approve on 2013-01-08

PS Jenkins bot (community): Approve (continuous-integration) on 2013-01-08

Compiz Maintainers: Pending requested 2013-01-08

Diff: 121 lines (+34/-15)

4 files modified

plugins/resize/src/logic/include/screen-interface.h (+1/-0)
plugins/resize/src/logic/src/resize-logic.cpp (+23/-15)
plugins/resize/src/screen-impl.h (+5/-0)
plugins/resize/src/window-impl.h (+5/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1097126: resize leaks memory in multiple locations calling resize::CompScreenImpl::findWindow() -> operator new()

High

Fix Released

Link a bug report

Related blueprints

3549. By Daniel van Vugt on 2013-01-08

A little more abstraction so Google Mock doesn't crash on "delete w" (because
the mocked version is not new'd). Also fixed another potential leak.

3548. By Daniel van Vugt on 2013-01-08

Fixed another potential leak and simplified previous leak fixes.

3547. By Daniel van Vugt on 2013-01-08

Fix memory leaks resulting from misuse (and poor design) of
resize::CompScreenImpl::findWindow()
(LP: #1097126)

3546. By Daniel van Vugt on 2013-01-08

Sort the plugin list to improve readability of CMake output (LP: #1096780). Fixes: https://bugs.launchpad.net/bugs/1096780.

Approved by PS Jenkins bot, Sam Spilsbury.

3545. By Daniel van Vugt on 2013-01-07

Be sure to treat \r and \n as word boundaries too. Otherwise CMake will read
expo's plugin name as "expo\n" from plugins/expo/CMakeLists.txt resulting
in weird and misleading "Disabled" messages for expo.
(LP: #1083027). Fixes: https://bugs.launchpad.net/bugs/1083027.

Approved by PS Jenkins bot, Sam Spilsbury.

3544. By MC Return on 2013-01-07

Fixed dimention->dimension typos.

Approved by Daniel van Vugt.

3543. By Michail Bitzes on 2013-01-07

Added missing glEnable/glDisableClientState calls for GL_TEXTURE_COORD_ARRAY and GL_VERTEX_ARRAY to make showmouse work with the new codebase.

Credits and thanks for this patch go to Michail Bitzes.

(LP: #1048267). Fixes: https://bugs.launchpad.net/bugs/1048267.

Approved by Daniel van Vugt.

3542. By Sam Spilsbury on 2013-01-07

Fixed: Clicking on semi-maximized windows in a different workspace fails to
switch to the correct workspace. (LP: #1037164). Fixes: https://bugs.launchpad.net/bugs/1037164.

Approved by Daniel van Vugt, PS Jenkins bot.

3541. By Sam Spilsbury on 2013-01-07

Port cubeaddon plugin to use new OpenGL plugin API.
(LP: #1020823)

Since the arrangement of the vertex data assumes quad usage, and GL_QUADS primitives are not available in OpenGL|ES, the option "deform caps" will be nonfunctional in OpenGL|ES builds. Fixes: https://bugs.launchpad.net/bugs/1020823.

Approved by Daniel van Vugt, PS Jenkins bot, Sam Spilsbury.

3540. By Sam Spilsbury on 2013-01-04

Fix definition of glShaderSource function pointer.

Its GLvoid glShaderSource (GLuint, GLsizei, const GLchar * const *, const GLint *); in the header file, not GLvoid glShaderSource (GLuint, GLsizei, const GLchar **, const GLint *); like the specification.

Use a function pointer cast to work around it.

(LP: #1095915). Fixes: https://bugs.launchpad.net/bugs/1095915.

Approved by PS Jenkins bot, Daniel van Vugt.