Compiz

opengl plugin FTBFS with clang

Bug #1095915 reported by Sam Spilsbury on 2013-01-04

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Compiz	Fix Released	Medium	Sam Spilsbury	Compiz 0.9.9.0
Mesa	Won't Fix	Medium	freedesktop-bugs #59013
compiz (Ubuntu)	Fix Released	Medium	Sam Spilsbury

Bug Description

[ 35%] Building CXX object plugins/opengl/CMakeFiles/opengl.dir/src/screen.cpp.o
/home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/experimental/plugins/opengl/src/screen.cpp:856:22: error:
      assigning to 'GLShaderSourceProc' (aka 'void (*)(GLuint, GLsizei, const
      GLchar **, const GLint *)') from incompatible type 'void (GLuint, GLsizei,
      const GLchar *const *, const GLint *)': type mismatch at 3rd parameter
      ('const GLchar **' (aka 'const char **') vs 'const GLchar *const *' (aka
      'const char *const *'))
    GL::shaderSource = glShaderSource;
                     ^ ~~~~~~~~~~~~~~
1 error generated.

Related branches

lp:~compiz-team/compiz/compiz.fix_1095915

Merged into lp:compiz/0.9.9 at revision 3540

PS Jenkins bot (community): Approve (continuous-integration) on 2013-01-04

Daniel van Vugt: Approve on 2013-01-04

Sam Spilsbury (smspillaz) on 2013-01-04

Changed in compiz:
status:	New → Confirmed
importance:	Undecided → Medium
assignee:	nobody → Sam Spilsbury (smspillaz)
milestone:	none → 0.9.9.0

Daniel van Vugt (vanvugt) on 2013-01-04

Changed in compiz:
status:	Confirmed → In Progress
Changed in compiz (Ubuntu):
status:	New → In Progress
importance:	Undecided → Medium
assignee:	nobody → Sam Spilsbury (smspillaz)

Revision history for this message

In freedesktop.org Bugzilla #59013, Sam Spilsbury (smspillaz) wrote on 2013-01-04:

glShaderSource is defined in the GLES2 spec as so:

void glShaderSource( GLuint shader,
  GLsizei count,
  const GLchar **string,
  const GLint *length);

However trunk mesa (and 9.1.0) has a definition like this:

GL_APICALL void GL_APIENTRY glShaderSource (GLuint shader, GLsizei count, const GLchar* const* string, const GLint* length);

The difference being const GLchar **string, vs const GLchar* const* string

That means that if you have a function pointer to glShaderSource using the old definition, and assign the new function to it, it will fail to compile.

(And I know that code using function pointers to core functionality is insane, but it is better than using ifdefs to switch between using function pointers where that functionality is extension-only, and real function declarations where it is core functionality)

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2013-01-04:

This is really a bug in mesa. glShaderSource is defined in the spec like so:

void glShaderSource( GLuint shader,
  GLsizei count,
  const GLchar **string,
  const GLint *length);

But in newer versions they've changed it to:

GL_APICALL void GL_APIENTRY glShaderSource (GLuint shader, GLsizei count, const GLchar* const* string, const GLint* length);

That's incorrect.

Bug Watch Updater (bug-watch-updater) on 2013-01-04

Changed in mesa:
importance:	Unknown → Medium
status:	Unknown → Confirmed

Revision history for this message

In freedesktop.org Bugzilla #59013, Idr (idr) wrote on 2013-01-04:

We just redistribute the official GLES2/gl2.h from Khronos. If anything, I believe the specification is incorrect. Please report upstream at khronos.org.

http://www.khronos.org/registry/gles/api/2.0/gl2.h

PS Jenkins bot (ps-jenkins) on 2013-01-04

Changed in compiz:
status:	In Progress → Fix Committed

Revision history for this message

In freedesktop.org Bugzilla #59013, Sam Spilsbury (smspillaz) wrote on 2013-01-05:

Okay, I've filed a bug upstream (https://www.khronos.org/bugzilla/show_bug.cgi?id=761)

Though, I'm wondering why it changed so recently.

Bug Watch Updater (bug-watch-updater) on 2013-01-06

Changed in mesa:
status:	Confirmed → Won't Fix

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2013-01-07:

Fix committed into lp:compiz at revision 3540, scheduled for release in Compiz 0.9.9.0

Changed in compiz (Ubuntu):
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-01-14:

This bug was fixed in the package compiz - 1:0.9.9~daily13.01.14-0ubuntu1

---------------
compiz (1:0.9.9~daily13.01.14-0ubuntu1) raring; urgency=low

  [ sampo555 ]
  * compiz crashed with SIGSEGV in DodgeAnim::applyDodgeTransform() (LP:
    #1048840)
  * compiz crashing if window un-/minimize animation is "Random" (LP:
    #1098185)

  [ Daniel van Vugt ]
  * Several leaks in new GLProgram from compileProgram() from
    GLScreen::getProgram() from GLWindowAutoProgram::getProgram() (LP:
    #1097644)

  [ Sam Spilsbury ]
  * Several leaks in ccsIntegratedSettingListAppend() ... from
    ccsGNOMEIntegrationBackendGetIntegratedSetting() from readSetting
    (gsettings.c:375) (LP: #1097661)

  [ MC Return ]
  * Thumbnail Window Previews: Flickering of background/glow and window
    title text (LP: #1098758)

[ Automatic PS uploader ]
* Automatic snapshot from revision 3561
-- Automatic PS uploader <email address hidden> Mon, 14 Jan 2013 04:03:09 +0000

Changed in compiz (Ubuntu):
status:	Fix Committed → Fix Released

Daniel van Vugt (vanvugt) on 2013-01-24

Changed in compiz:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

freedesktop-bugs #59013
[RESOLVED NOTOURBUG] Edit
auto-www.khronos.org #761 Edit

Bug watches keep track of this bug in other bug trackers.