Reviewing Sam's concerns again:
1. "if the input shape region changes while the window is minimized". Yes this will be a potential (albeit unlikely and rare) problem. And again only a problem when using Unity :(
2. Code clean up. As usual I would like to avoid cleaning up code as part of a bug fix. They should be separate activities if possible.
OK, well I don't have a good answer to #1 right now. Only two simple solutions come to mind:
(a) Approve andyrock's revert of r3513. It will cause a regression of LP: #1087193 but that's a minor issue compared to bug 1089811.
(b) Fix Unity, by deleting the offending code: UnityWindow::[un]minimize[d]()
Reviewing Sam's concerns again:
1. "if the input shape region changes while the window is minimized". Yes this will be a potential (albeit unlikely and rare) problem. And again only a problem when using Unity :(
2. Code clean up. As usual I would like to avoid cleaning up code as part of a bug fix. They should be separate activities if possible.
OK, well I don't have a good answer to #1 right now. Only two simple solutions come to mind: :[un]minimize[ d]()
(a) Approve andyrock's revert of r3513. It will cause a regression of LP: #1087193 but that's a minor issue compared to bug 1089811.
(b) Fix Unity, by deleting the offending code: UnityWindow:
Until we can do (b), I think I will chose (a).