Code review comment for lp:~vanvugt/compiz/fix-1028809

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

The only ones would be switcher, staticswitcher, shift, ring.

Those call glDraw directly, so the o/b/s settings won't be applied to
those previews.

On Wed, Nov 21, 2012 at 5:32 PM, Daniel van Vugt
<email address hidden> wrote:
> That comment is old and I'm not yet aware of any use case where it applies any more. Certainly I would not move the o/b/s setting into DrawTexture unless I really-really had to. It gets called too many times per frame.
>
> Maybe as part of this review we should all test for plugins where o/b/s used to work and doesn't any more. If no one can find a combination that's broken then it's probably not an issue.
> --
> https://code.launchpad.net/~vanvugt/compiz/fix-1028809/+merge/135329
> Your team Compiz Maintainers is requested to review the proposed merge of lp:~vanvugt/compiz/fix-1028809 into lp:compiz.

--
Sam Spilsbury

« Back to merge proposal