Code review comment for lp:~vanvugt/compiz-core/fix-startup-plugins

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

An improvement. But...

Important:

You also need to update src/privatescreen/tests/test-privatescreen.cpp

Less important:

It doesn't handle cases where a blacklisted plugin would load on a subsequent attempt - e.g. because it got installed while compiz was running.

I also have a preference for giving better names to a many of the variables here.

PS I do agree about using find() not count() - but both are O(log(n)) in an RB-tree, not liner.

review: Needs Fixing

« Back to merge proposal