lp:~vanvugt/compiz-core/fix-988684

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz-core/0.9.8 at revision 3115

Sam Spilsbury: Approve on 2012-04-27

Diff: 12 lines (+0/-3)

1 file modified

src/screen.cpp (+0/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #988684: [regression] Starting a second instance of compiz (without --replace) causes the existing instance to shut down (gracefully)	Medium	Invalid
Bug #989545: [regression] compiz --replace fails to start	Medium	Fix Committed

Link a bug report

Related blueprints

3116. By Daniel van Vugt on 2012-04-27

Don't clear selections in ~PrivateScreen because it causes a race between
the existing and the new compiz instances, breaking --replace and non-replace
behaviour. (LP: #988684) (LP: #989545)

This simply deletes two lines of code I introduced in my cleanup r3108.

3115. By Daniel van Vugt on 2012-04-27

Don't clear selections you don't own, because it's likely to cause the
actual owning instance to shut down. (LP: #988684)

3114. By Sam Spilsbury on 2012-04-26

Always paint with infiniteRegion as the clip region if the window is
transformed and always use the supplied region if painting with offset or on
transformed screen. (LP: #987639)

3113. By Alan Griffiths on 2012-04-25

Get rid of PseudoNamespace

3112. By Alan Griffiths on 2012-04-25

Remove PluginManager dependency on ::screen

3111. By Alan Griffiths on 2012-04-24

Reorder privatescreen.h header

3110. By Sam Spilsbury on 2012-04-24

Always use the asynchronous codepaths in core.
(LP: #862430) (LP: #892012) (LP: #923683) (LP: #932520)

 * CompWindow::move is now just a wrapper around CompWindow::configureXWindow
 * CompWindow::configureXWindow will always call through to moveNotify
 * moveNotify and resizeNotify are only ever called pre-request in the case of
   managed windows (SubstructureRedirectMask guaruntees they will end up in
   the right place) and post ConfigureNotify for override redirect windows
 * resizeNotify is always called post ConfigureNotify regardless of whether
   or not the window is managed or not
 * various const correctness where it made sense
 * cleaned up the whole geometry.width () + geometry.border () * 2 nonsense
 * removed priv->width and priv->height , which was just redundant data used
   for window shading and honestly, is a ticking time bomb for future
   maintainers.
 * CompWindow::syncPosition is now deprecated and a no-op
 * Removed the majority of PrivateWindow::updateFrameWindow - this function
   had a lot of redundant code which PrivateWindow::reconfigureXWindow had
   anyways - the big work there was to send synthetic ConfigureNotify events
   to ourselves to notify windows moving within frame windows that don't move
   themselves. Its safer to use reconfigureXWindow in this case and probably
   more sane too. We should look into removing the other update* functions.

3109. By Łukasz Zemczak on 2012-04-23

Reverting the introduction of bindTexture - we don't need it, since the fix
is actually a ONE LINER! Thanks Sam! (LP: #770283)

3108. By Daniel van Vugt on 2012-04-20

Tidy up PrivateScreen construction and destruction:
 - Remove a local masking a member variable.
 - Add members missing from the constructor's initialization list.
 - Free more resources, more clearly, in the destructor.

3107. By Alan Griffiths on 2012-04-20

Remove some pointless exception throwing and catching from the normal execution path.