Compiz Core

Merge lp:~vanvugt/compiz-core/fix-988684 into lp:compiz-core/0.9.8

  1. fix-988684
  2. Merge into 0.9.8
Proposed by Daniel van Vugt
Status: Merged
Merged at revision: 3115
Proposed branch: lp:~vanvugt/compiz-core/fix-988684
Merge into: lp:compiz-core/0.9.8
Diff against target: 12 lines (+0/-3)
1 file modified
src/screen.cpp (+0/-3)
To merge this branch: bzr merge lp:~vanvugt/compiz-core/fix-988684
Reviewer Review Type Date Requested Status
Sam Spilsbury Approve
Review via email: mp+103842@code.launchpad.net

This proposal supersedes a proposal from 2012-04-27.

Description of the change

Don't clear selections in ~PrivateScreen because it causes a race between
the existing and the new compiz instances, breaking --replace and non-replace
behaviour. (LP: #988684) (LP: #989545)

This simply deletes two lines of code I introduced in my cleanup r3108.

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Hmm, it should be possible to clear the selection after destroying the selection window. The new selection owner is waiting for the window to be destroyed after requesting to take the selection.

In any case, the selection owner is implicitly cleared when the connection is closed anyways (or at least ... it should be)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/screen.cpp'
2--- src/screen.cpp 2012-04-25 09:21:24 +0000
3+++ src/screen.cpp 2012-04-27 10:06:21 +0000
4@@ -5302,9 +5302,6 @@
5 if (invisibleCursor != None)
6 XFreeCursor (dpy, invisibleCursor);
7
8- if (wmSnAtom != None)
9- XSetSelectionOwner (dpy, wmSnAtom, None, CurrentTime);
10-
11 if (wmSnSelectionWindow != None)
12 XDestroyWindow (dpy, wmSnSelectionWindow);
13

Subscribers

People subscribed via source and target branches