Merge lp:~vanvugt/compiz-core/fix-972519 into lp:compiz-core

Proposed by Daniel van Vugt
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3091
Merged at revision: 3091
Proposed branch: lp:~vanvugt/compiz-core/fix-972519
Merge into: lp:compiz-core
Diff against target: 11 lines (+1/-1)
1 file modified
src/timer/src/timeouthandler.cpp (+1/-1)
To merge this branch: bzr merge lp:~vanvugt/compiz-core/fix-972519
Reviewer Review Type Date Requested Status
Compiz Maintainers Pending
Review via email: mp+101688@code.launchpad.net

Description of the change

Avoid comparison between signed and unsigned integers (LP: #972519)

Strange. All versions of gcc should have reported this as an error. But
obviously gcc prior to 4.7 had bugs and failed to find all such errors.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/timer/src/timeouthandler.cpp'
2--- src/timer/src/timeouthandler.cpp 2012-02-06 17:44:17 +0000
3+++ src/timer/src/timeouthandler.cpp 2012-04-12 06:57:19 +0000
4@@ -57,7 +57,7 @@
5
6 for (it = priv->mTimers.begin (); it != priv->mTimers.end (); it++)
7 {
8- if ((int) timer->minTime () < (*it)->minLeft ())
9+ if (timer->minTime () < (*it)->minLeft ())
10 break;
11 }
12

Subscribers

People subscribed via source and target branches