Code review comment for lp:~vanvugt/compiz-core/fix-938478

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> What do you think about using RTLD_NOW in --debug ?

Differences between debug and normal use always cause pain.

I've seen systems where plugins can be flagged as "trusted" or "untrusted" and loaded with more or less paranoid options accordingly. So a separate option might make sense. Vis:

compiz plug1 plug2 --load-check plug3 --no-load-check plug4

But that's probably too much work for the problem.

> I think that alan_g was working on getting the plugin loader under test,

The plugin loader code is under test - but to do that the file system is mocked out.

> we could probably unit test loading all the plugins as part of our
> testsuite, that would catch any undefined symbols in an automated way.

It isn't really a /unit/ test - and the point of a plugin architecture is that "all the plugins" isn't a set known at build time.

Also, to emulate the symbols available at runtime requires a pretty complete replication of the runtime binary. (Easier done as a command line switch?)

« Back to merge proposal