Code review comment for lp:~vanvugt/compiz-core/fix-930412

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I don't think "We'll need to trigger a rebuild of all the plugins". Existing plugins using the old generated code will still work without a rebuild if necessary.

Also regarding generated *Options, it is bad design to have so much activity in the constructor of any class (which happens to be the cause of this bug). I think separating initialization from construction was always going to be cleaner. I don't think any of this qualifies as a hack. In fact, this proposal removes hacks such as PrivateScreen::addScreenActions ()

« Back to merge proposal