Code review comment for lp:~vanvugt/compiz-core/fix-928044
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Yes, I think the thing that changed was the introduction of libcompiz_core as a shared library. Because the builds worked perfectly before that.
The compiz.pc.in fix was enough to stop the build failing in 'text'. But then it was still failing in 'mousepoll' because mousepoll had somehow automagically lost the -L${prefix}/usr/lib it gets from compiz.pc and so couldn't find libcompiz_core.
${libdir} is subject to change depending on which package you're building. For plugins, ${libdir} is the plugins directory. So of course, the linker can't find libcompiz_core there. That's why we need to use the unambiguous COMPIZ_LIBDIR instead of libdir.