Code review comment for lp:~vanvugt/compiz-core/bettertimers

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

Shouldn't you include the changes for this:

+ /*
+ * Note the use of delay = 1 instead of 0, even though 0 would be better.
+ * A delay of zero is presently broken due to CompTimer bugs;
+ * 1. Infinite loop in CompTimeoutSource::callback when a zero
+ * timer is set.
+ * 2. Priority set too high in CompTimeoutSource::CompTimeoutSource
+ * causing the glib main event loop to be starved of X events.
+ * Fixes for both of these issues are being worked on separately.
+ */
+ paintTimer.start
+ (boost::bind (&CompositeScreen::handlePaintTimeout, cScreen),
+ delay);

And setting lp:~vanvugt/compiz-core/fix-880707.2 as a prerequisite of this branch?

« Back to merge proposal