Code review comment for lp:~vadim-tk/galera/centos5-build-instruction

Revision history for this message
Vadim Tkachenko (vadim-tk) wrote :

Alex,

Well, people usually do not read what is written on web pages :),
usually file in source code works better.

I am fine with all your proposals.
If you do not want to include this file, that also fine.

On Sat, Oct 8, 2011 at 3:52 PM, Alex Yurchenko
<email address hidden> wrote:
> Vadim, some questions:
>
> 1) Perhaps this file should be called BUILD.CentOS, or maybe even just
> BUILD.txt or README.build, because it makes sense to add build
> instructions for debian too?
>
> 2) To build you also need check and scons packages, should those be
> added?
>
> 3) This does not seem to be any more informative than what we have at
> https://launchpad.net/galera, so is this file really needed (in the
> proposed form)?
>
> Regards,
> Alex
>
>
>
> --
> https://code.launchpad.net/~vadim-tk/galera/centos5-build-instruction/+merge/78734
> You are the owner of lp:~vadim-tk/galera/centos5-build-instruction.
>

--
Vadim Tkachenko, CTO, Percona Inc.
Phone +1-888-401-3403,  Skype: vadimtk153
Schedule meeting: http://tungle.me/VadimTkachenko

Join us at Percona Live London!
http://www.percona.com/live/london-2011/

« Back to merge proposal