Code review comment for lp:~vadim-tk/galera/centos5-build-instruction

Revision history for this message
Alex Yurchenko (ayurchen) wrote :

Vadim, some questions:

1) Perhaps this file should be called BUILD.CentOS, or maybe even just
BUILD.txt or README.build, because it makes sense to add build
instructions for debian too?

2) To build you also need check and scons packages, should those be
added?

3) This does not seem to be any more informative than what we have at
https://launchpad.net/galera, so is this file really needed (in the
proposed form)?

Regards,
Alex

« Back to merge proposal