Code review comment for ~utkarsh/ubuntu/+source/rabbitmq-server:lp1921425-logrotate-issue-groovy

Summary - Could you please:
- reduce the fix to just fix the double rotation
- if you want to add the #947873 fix add a LP bug to track/test/discuss about it

---

From the log:
   - Use logrotate daily instead of weekly, and do not override the
     number of logs, so we don't keep too much of them.

While I agree to this for Hirsute - and I agree to fix the double rotation, for the SRU shouldn't we keep weekly (as is) and the number of logs (as is) and only fix the double-rotation to no more happen?

---

Further another "potential regression" is increased disk space consumption as we formerly kept N/2 reasonable logs and now we will keep N. So the amount doubles.

---

While I see how https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=947873 is important to logging I don't see a clear path from the bug you try to SRU-fix to that change. This would either need an update to that bug description or filing a new one. But the bug you have is already rather busy (a lot of text), so maybe a new bug would be better.

---

Finally the change will also change the place of the logs
New:
+StandardOutput=append:/var/log/rabbitmq/rabbitmq-server.log
+StandardError=append:/var/log/rabbitmq/rabbitmq-server.error.log
Old:
/usr/lib/rabbitmq/bin/rabbitmq-server "$@" > "/var/log/rabbitmq/startup_log" 2> "/var/log/rabbitmq/startup_err"
Which for an SRU I think is unwanted.