Code review comment for ~utkarsh/ubuntu/+source/multipath-tools:merge-multipath-tools-impish

Revision history for this message
Robie Basak (racb) wrote :

We reviewed and iterated on this mostly offline. Thank you for working on upstreaming a considerable part of this delta. Lots of that is waiting on Debian, so we concluded that there's no need to block this merge on that. The important thing is that work is being done to reduce the delta.

> - d/multipath.conf: Install friendly names multipath.conf by default,
> instead of generating it in every installer.

We decided to keep this for now, as removing it has consequences for users in the future potentially, as they'll appear to have a custom configuration when they didn't customize it themselves (and therefore conffile prompts if we ever ship that conffile again in the future).

> - d/p/enable-find-multipaths.patch: re-enable find_multipaths by
> default -- see the removed 'add_find-multipaths.patch' (LP 1463046)

It looks to me that this is a workaround that just switches the default find_multipaths behaviour to "on", from "strict", and that "strict" is still buggy in the problem case. Users could be confused if they enable "strict" manually, and further the manpage still declares "strict" to be the default even thoughthis default is changed by this patch. I'll file a separate bug for this.

review: Approve

« Back to merge proposal