Code review comment for ~utkarsh/ubuntu/+source/libapache2-mod-perl2:fix-sigsev-perl-parse

Revision history for this message
Bryce Harrington (bryce) wrote :

* Changelog:
  - [-] old content and logical tag match as expected
  - [√] changelog entry correct version and targeted codename
  - [√] changelog entries correct
  - [x] update-maintainer has been run

* Actual changes:
  - [-] no upstream changes to consider
  - [-] no further upstream version to consider
  - [ ] debian changes look safe

* Old Delta:
  - [-] dropped changes are ok to be dropped
  - [-] nothing else to drop
  - [√] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [-] no new patches added
  - [√] patches match what was proposed upstream
  - [√] patches correctly included in debian/patches/series
  - [√] patches have correct DEP3 metadata

* Build/Test:
  - [√] build is ok
  - [ ] verified PPA package installs/uninstalls
  - [√] autopkgtest against the PPA package passes
  - [-] sanity checks test fine

Verified build and autopkgtest work fine locally for me too.

Don't forget to run `update-maintainer`, which is required when you're making the first modification on a package sync'd from debian. (E.g. whenever you have a *ubuntu1 or *ubuntu0.1 or similar version).

Otherwise LGTM, +1. Will sponsor the upload directly.

review: Approve

« Back to merge proposal