Code review comment for ~utkarsh/ubuntu/+source/isc-dhcp:fix-nm-regression

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hi,
does the patch "Fixed_gcc_10_compilation_issues.patch" really have to go away?
isn't it enough to just use gcc-9 and be good without non-applying the patch?
The patch looks very safe except the memcpy, maybe the upstream discussion on this continued and there is a better version of it?

Furthermore could we only use gcc-9 on ppc64el please, and example of that is here
https://git.launchpad.net/ubuntu/+source/qemu/commit/?id=952155324e6f461878a8fbb4f33d2a37910a5954

I we could do both that would be much less deviation from how it is supposed to work.

Finally - we can't gcc-9 build this forever - therefore we need some hope to ever be able to drop this. Due to that IMHO there must be an upstream bug about it (if it exists chime in / if it does not exists file it). Then link it from the commit that you add here. Upstream in this case might be Debian IFF it is only happening when Fixed_gcc_10_compilation_issues.patch is applied.

review: Needs Fixing

« Back to merge proposal