Code review comment for ~utkarsh/ubuntu/+source/freeipmi:merge-freeipmi-hirsute

stirling:~/pkg/Ipmitool/ipmitool-gu$ syncpackage --force freeipmi
Loading Gnome
Loading Google
Loading Windows (alt)
Loading file
Loading keyczar
Loading multi
Loading pyfs
Loading KWallet
Loading SecretService
Loading Windows
Loading chainer
Loading macOS
Source freeipmi -> hirsute/Proposed: current version 1.6.4-3ubuntu2, new version 1.6.6-3
New changes:
freeipmi (1.6.6-3) unstable; urgency=medium

  * remove sysvinit-utils dependency as not needed anymore
  * disable initd scripts in configure instead remove them with rm
  * remove maintscript entries related to very old versions
  * update ipmidetectd service, /etc/default/ipmidetectd was removed
  * use upstream systemd service files and add pkg-config, systemd
    and libsystemd-dev to build-depends (Closes: #924570)
  * wrap and sort
  * fix libipmiconsole.pc path
  * fix systemd service files permission
  * specify that rules require root
  * Bump Standards-Version to 4.5.1
  * add repository to upstream metadata

 -- Fabio Fantoni <email address hidden> Sat, 06 Feb 2021 19:46:06 +0100

freeipmi (1.6.6-2) unstable; urgency=medium

  [ Fabio Fantoni ]
  * remove duplicate entry in freeipmi-ipmidetect.maintscript
  * remove debian/compat and use debian-compat in debian/control
  * update lintian override about man
  * fix systemd service files install
  * change duplicate short description of freeipmi-ipmiseld
  * add missing '/var/cache/ipmiseld/' directory in package freeipmi-ipmiseld
    (Closes: #793186)
  * fix service restart in postrotate of bmc-watchdog.logrotate
  * d/rules: small improvement to avoid an unexpected case
  * Rise compat level to 13
  * libipmimonitoring-dev: move .pc file to a multiarch location
    (Closes: #981386)

  [ Bernd Zeimetz ]
  * Setting Fabio Fantoni as Maintainer, moving myself to uploaders.
  * Removing Yaroslav Halchenko from Uploaders.

 -- Bernd Zeimetz <email address hidden> Tue, 02 Feb 2021 20:53:25 +0100

freeipmi (1.6.6-1) unstable; urgency=medium

  [ Fabio Fantoni ]
  * [58415f9] Add break/replace libipmimonitoring5a to libipmimonitoring6
   libipmimonitoring6 avoid fails on upgrade for files present in both
   packages making upgrade failing, including upgrade from
   oldstable (Stretch) the the latest (Buster)
    (Closes: #925139)
  * [995c9ab] mark freeipmi-common Multi-Arch: foreign.
    Thanks to Helmut Grohne (Closes: #941145)
  * [875d980] use dh_autoreconf instead of dh_autotools-dev.
    I did this patch based on ubuntu patch plus I removed autotools-dev build-dep.
    that seems to me not needed anymore after this change
    (and is also installed as dep. of automake, dep. of dh-autoreconf)
    Thanks to Steve Langasek (Closes: #841657)

  [ Bernd Zeimetz ]
  * [83bcf9c] Disable reprotest for now.
    Fails to build with some weird fail.

  [ Andreas Hasenack ]
  * [6fee89c] d/NEWS: explain the removal of RUN= settings in /etc/default configuration files.
  * [678414e] d/rules: Build with "bindnow"
    See
    https://wiki.debian.org/Hardening#DEB_BUILD_HARDENING_BINDNOW_.28ld_-z_now.29
  * [bab13c0] d/freeipmi-ipmidetect.maintscript: handle removal of
    obsolete /etc/default/ipmidetectd configuration file
  * [1a77722] d/NEWS: fix typo

  [ Bernd Zeimetz ]
  * [da10921] New upstream version 1.6.6
  * [1e10f54] snapshot changelog"

  [ Debian Janitor ]
  * [b621349] Trim trailing whitespace.
    Changes-By: lintian-brush
    Fixes: lintian: trailing-whitespace
    See-also: https://lintian.debian.org/tags/trailing-whitespace.html
  * [8ee3600] Use secure copyright file specification URI.
    Changes-By: lintian-brush
    Fixes: lintian: insecure-copyright-format-uri
    See-also: https://lintian.debian.org/tags/insecure-copyright-format-uri.html
  * [3c930ee] Use secure URI in debian/watch.
    Changes-By: lintian-brush
    Fixes: lintian: debian-watch-uses-insecure-uri
    See-also: https://lintian.debian.org/tags/debian-watch-uses-insecure-uri.html
  * [0272574] Use secure URI in Homepage field.
    Changes-By: lintian-brush
    Fixes: lintian: homepage-field-uses-insecure-uri
    See-also: https://lintian.debian.org/tags/homepage-field-uses-insecure-uri.html
  * [15322d3] Set upstream metadata fields: Bug-Submit (from ./configure).
    Changes-By: lintian-brush
    Fixes: lintian: upstream-metadata-file-is-missing
    See-also: https://lintian.debian.org/tags/upstream-metadata-file-is-missing.html
    Fixes: lintian: upstream-metadata-missing-bug-tracking
    See-also: https://lintian.debian.org/tags/upstream-metadata-missing-bug-tracking.html
  * [e37a4a5] Drop unnecessary dependency on dh-autoreconf.
    Changes-By: lintian-brush
    Fixes: lintian: useless-autoreconf-build-depends
    See-also: https://lintian.debian.org/tags/useless-autoreconf-build-depends.html
  * [fd12a3b] Changed vcs type from git to Git based on URL.
    Changes-By: lintian-brush
    Fixes: lintian: vcs-field-mismatch
    See-also: https://lintian.debian.org/tags/vcs-field-mismatch.html

  [ Fabio Fantoni ]
  * [872e85f] make the build reproducible.
    Replace man pages dates with the timestamp from the latest
    debian/changelog entry using the variable SOURCE_DATE_EPOCH to make the
    package build reproducibly.
    I updated the patch that was not applycable anymore.
    Thanks to Eduard Sanou (Closes: #794792)
  * [b921b64] Revert "Disable reprotest for now."
    This reverts commit 83bcf9c163ee9d2d9089961f556fc8afe60b501f.
  * [ad3868d] remove old unused debian patches
  * [59336cc] fix few things spotted by lintian
    - file-contains-trailing-whitespace debian/changelog
    - useless-autoreconf-build-depends dh-autoreconf
    - homepage-field-uses-insecure-uri
    - insecure-copyright-format-uri
    - unused-file-paragraph-in-dep5-copyright paragraph at line 14
      (files not present anymore)
    - debian-watch-uses-insecure-uri
    - manpage-has-errors-from-man
    - unused-override manpage-has-errors-from-man
  * [a8fd850] remove unneeded pre-depends on very old dpkg
    pre-depends should be avoided FWIK and the dpkg >=1.15.7.2~ is very old
    (before actual oldoldstable, so should be not needed anymore
  * [0758379] Rise compat level to 11
  * [cdf746c] use dh_missing instead of the deprecated option
    --fail-missing on dh_install is deprecated and removed in dh 12
  * [f5c346f] remove init files and use systemd ones
    systemd service are already present and systemd is default in latest debian
    Note: /etc/logrotate.d/bmc-watchdog to remove or changed it and its systemd
    service
  * [1dc31f5] handle removal of obsolete /etc/default/ipmidetectd
    configuration file
    taken from ubuntu
  * [e0c8613] build with hardening "bindnow"
    is already used in ubuntu packages

 -- Bernd Zeimetz <email address hidden> Fri, 29 Jan 2021 21:27:29 +0100
Sync this package [y|N]? y
Request succeeded; you should get an e-mail once it is processed.