Code review comment for lp:~usc-isi/nova/instance_type_extra_specs

Revision history for this message
Brian Waldon (bcwaldon) wrote :

Thanks for making an extension, Lorin. Here are the last few items:

110, 125: Can you please add a 'os-' prefix to your extension alias? See the volumes extension as an example.

529: This file should probably be moved into nova/tests/api/openstack/contrib. The other test files are fine where they are.

983: I think we might want version 0.6.1, not latest. Thoughts?

review: Needs Fixing

« Back to merge proposal