Code review comment for lp:~usc-isi/nova/instance_type_extra_specs

Revision history for this message
Vish Ishaya (vishvananda) wrote :

This seems good. Just a question really. Why is the:
inst_dict[i['name']] = _inst_type_query_to_dict(i)

necessary. It seems like the joined load should handle populating the subobjects. If there is some reason to convert to nested dictionaries, is utils.to_primitive() lacking something that requires a custom method to be written?

review: Needs Information

« Back to merge proposal