Code review comment for lp:~usb-creator-hackers/usb-creator/debian

Revision history for this message
Evan (ev) wrote :

With respect to the top of changelog, the approach we've always taken is to keep the pocket as UNRELEASED until we're ready to upload. We then run dch -r but do not commit the change and upload. Once the upload is accepted by the archive, we run debcommit -r. This commits the aforementioned change and creates a tag.

I think the new description is inaccurate. usb-creator can write debian-installer images (including the Ubuntu alternate and server CDs) to USB disks as well. What do you think of changing it to,
"Startup Disk Creator converts a USB key or SD card into a volume from which you
can start up and run Ubuntu. You can also store files and settings in any space left over.

The program also works for Debian, or any other Debian-based OS for which you have a CD or .iso image."
Credit to Matthew Paul Thomas for coming up with that this morning :).

"Startup disk creator" should probably be capitalized to match the .desktop files, unless convention forbids it. The Debian policy doesn't specify a behavior: http://www.debian.org/doc/packaging-manuals/menu.html/ch3.html#s3.3

Also, unless I'm misreading the discussion we had in merge 25344 (https://code.edge.launchpad.net/~dmitrij.ledkov/usb- creator/packaging/+merge/25344), I thought we were going to upload to Debian, sync to Ubuntu, and upload ubuntu1 if we're past the Debian Import Freeze? If this is the case, I'm confused by the presence of both 0.2.23 and 0.2.23ubuntu1 sections in the changelog. Perhaps I'm just not following the process you have in mind though. Why not just upload to Debian from trunk? Apologies if I'm forgetting comments I've made to the contrary. My brain isn't fully operational yet this morning :).

review: Needs Fixing

« Back to merge proposal