Code review comment for lp:~ursinha/uci-engine/private-lp-mthood

Revision history for this message
Ursula Junque (ursinha) wrote :

> On 05/07/2014 12:12 PM, Ursula Junque wrote:
> > Thanks for reviewing, Andy.
> >
> >>> === modified file 'branch-source-
> >> builder/cupstream2distro/launchpadmanager.py'
> >>
> >>> +sys.path.append(os.path.join(os.path.dirname(__file__), '../ci-utils'))
> >>
> >> I don't think we need sys.path.append stuff in our code anymore.
> >
> > This branch is on top of mthood one, that is a tad far from lp:uci-
> engine/trunk. Are these things you mention available since when? I think this
> should be changed in case we're merging this with trunk, otherwise I'm not
> sure it's going to work? (same apply for other comments regarding things we
> have now and didn't have when this was created).
>
> yes. it was added here:
>
> <http://bazaar.launchpad.net/~canonical-ci-engineering/uci-
> engine/mthood/revision/320>

Fixed in 442.

« Back to merge proposal