I'm being a little over-protective, but as per: "/tmp/dput.cf" - Seems
like we should either make a constant for that, or (and I don't know the
code structure/flow, have pass this value down to the function via
upload_package.py
This is beyond the scope of this MP, but a tip: We now have a
unit_config module: ci_utils.unit_config that was written to handle this
stuff for all our services.
I don't understand the details well enough, but should this value come
from our unit_config rather than being hard-coded? Actually it looks
like deploy.py might be setting this in the unit_config?
> === modified file 'branch- source- builder/ cupstream2distr o/launchpadmana ger.py'
> +sys.path. append( os.path. join(os. path.dirname( __file_ _), '../ci-utils'))
I don't think we need sys.path.append stuff in our code anymore.
> === modified file 'branch- source- builder/ cupstream2distr o/packagemanage r.py'
> - cmd = ["dput", ppa, source. changes" .format( source, version_ for_source_ file)]
> + cmd = ["dput", "-u", "-c", "/tmp/dput.cf", ppa,
> "{}_{}_
I'm being a little over-protective, but as per: "/tmp/dput.cf" - Seems
like we should either make a constant for that, or (and I don't know the
code structure/flow, have pass this value down to the function via
upload_package.py
> === modified file 'branch- source- builder/ cupstream2distr o/settings. py'
> +PRIVATE_LAUNCHPAD = _cfg.get( 'private_ launchpad' , None)
This is beyond the scope of this MP, but a tip: We now have a unit_config that was written to handle this
unit_config module: ci_utils.
stuff for all our services.
> === modified file 'branch- source- builder/ watch_ppa. py'
def get_launchpad_ log(url) : '/launchpad. net/',' /api.launchpad. net/devel/ ') r.get_launchpad () get_lp_ api_url( api_version= "devel" ) lp_login( ) get(api_ url)
> '''Retrieves the build log from launchpad (thanks to celso).'''
> if not url:
> return None
> - api_url = url.replace(
> - lp = launchpadmanage
> + api_url = launchpad.
> + lp = launchpad.
> return lp._browser.
looks like the "url" parameter to this function is now ignored. Should
we remove it and refactor the caller of it?
> === added file 'create_ private_ lp_creds. py'
> +sys.path.insert(0, os.path. join(os. path.dirname( __file_ _), './ci-utils'))
again - don't think you need to alter sys.path anymore.
> +web_root ="https:/ /mthoodapi. lacinonac. com/"
I don't understand the details well enough, but should this value come
from our unit_config rather than being hard-coded? Actually it looks
like deploy.py might be setting this in the unit_config?