Code review comment for lp:~ursinha/ubuntu-ci-services-itself/ppa-add-private

Revision history for this message
Ursula Junque (ursinha) wrote :

> Do you think these tests are enough? I deployment similar code yesterday and
> it seemed to me reserve() wasn't respecting the settings.PRIVATE_ONLY
> variable, and I couldn't find any logs (gunicorn issue, I think). Is there
> anything else I need to do besides setting that on unit_config? Tests are
> passing now but maybe I'm not testing this as I should.

s/deployment/deployed/

« Back to merge proposal