Code review comment for lp:~ursinha/launchpad/bug-418345-language-index-migration

= Summary =

This branch migrates the template of language-index page to the new format.
The bug that's tracking this change is bug 418345.
It also has a fix for test_translationlinksaggregator, that was relying on the database data order and started to fail.
I've added a 3-line fix for bug 404898, because it wasn't worthy creating a separated branch for it. Besides, the fix is related to the main change here, that's bug 418345.

== Pre-implementation notes ==

It was discussed with rockstar about how to deal with the context menu now, and he said we should now use NavigationMenu instead of ContextMenu. So, considering nothing else in translations was using LanguageContextMenu, I've changed this to inherit NavigationMenu, and renamed it to LanguageNavigationMenu.

== Tests ==

This should test all changes, including a fix for test_translationlinksaggregator:
 bin/test -vvt lp.translations.*

To test specifically the template migration changes:
 bin/test -vvt xx-language

== Demo and Q/A ==

To check the changed pages, go to:
 - https://translations.launchpad.dev/+languages/us
 As a regular user you should see the changed layout.
 As an admin user, you should also be able to see the 'Administer' link as well, in the new format.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
 lib/lp/translations/browser/configure.zcml
 lib/lp/translations/browser/tests/language-views.txt
 lib/lp/translations/browser/language.py
 lib/lp/translations/browser/tests/test_translationlinksaggregator.py
 lib/lp/translations/templates/language-index.pt
 lib/lp/translations/stories/standalone/xx-language.txt
 lib/lp/translations/templates/language-portlet-top-contributors.pt