Code review comment for lp:~uriboni/webbrowser-app/undo-close-tab
Revision history for this message
| Olivier Tilloy (osomon) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
> We had the same problem in the qml-tabs-model MR, and I fixed the
> problem already there. Given that this code presumably will go in the
> same silo, and that CI seems to be happy about the tests anyway
> (why ?), can we avoid fixing this here too and then having to solve
> the conflict ?
Nothing guarantees that this will go in the same silo as the qml-tabs-model MR (especially so close to the code freeze for OTA-8). Branches should be mergeable on their own, unless one has a hard dependency on another one (but this is not the case here).
CI didn’t complain because it doesn’t run autopilot tests on desktop, only on a phone. I’ve been bugging the CI team about that, but without success so far. Until we get automated CI for desktop, we’ll need to run the tests ourselves manually to ensure they pass everywhere.