Code review comment for lp:~uriboni/webbrowser-app/topsite-previews

Revision history for this message
Olivier Tilloy (osomon) wrote :

There used to be a good reason for making the name of the preview file a unique ID as opposed to a hash of the URL, but at the moment I fail to remember that good reason. The relevant revision is http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/revision/823.1.16, unfortunately it doesn’t elaborate on why this was done. I’ll keep thinking about it, I’m pretty sure using the URL was not a good idea for some reason.

« Back to merge proposal