webbrowser_app.tests.test_tabs.TestTabsFocus.test_focus_on_close is broken on desktop
> And in test_shouldNotInsertTabAtInvalidIndex, you should also verify > that currentIndex and currentTab remain unchanged.
This hasn’t been done.
846 + // verify that when the model is not empty -1 is not a valid 847 + // current index anymore
s/anymore// : -1 never was a valid value for currentIndex, at least not in the current implementation in trunk
« Back to merge proposal
webbrowser_ app.tests. test_tabs. TestTabsFocus. test_focus_ on_close is broken on desktop
> And in test_shouldNotI nsertTabAtInval idIndex, you should also verify
> that currentIndex and currentTab remain unchanged.
This hasn’t been done.
846 + // verify that when the model is not empty -1 is not a valid
847 + // current index anymore
s/anymore// : -1 never was a valid value for currentIndex, at least not in the current implementation in trunk