Code review comment for lp:~uriboni/webbrowser-app/newtabview-listviews

Revision history for this message
Olivier Tilloy (osomon) wrote :

I have profiled the solution I was suggesting in my first comment. With a database of 100000 bookmarks, instantiating the entire view takes 600ms, and it is instantly responsive.

It works well when all sections are expanded, but it slows down considerably when all sections are collapsed (presumably because then there are 1000 invisible delegates instantiated for each section, so if there are 10 collapsed sections on screen that’s 10000 delegates instantiated at any given time).

On top of that the layout of the view is incorrect after expanding/collapsing a section, because the implementation of ListView computes an estimate of its contentHeight when using sections, instead of using the real content height.

Nested list views may not be such a bad idea after all…

« Back to merge proposal