Code review comment for lp:~uriboni/webbrowser-app/new-tab-wide-format

If I swipe a bookmark to the right to delete it, hovering over it still displays the grip that allows dragging it to a different folder (partially clipped by the window). I would expect this grip to be disabled/hidden while awaiting confirmation of whether to delete or not.

If I open a new tab, then open the history view (either from the drawer menu or with Ctrl+H), then close it, the sections header’s rendering is busted (the background color is drawn, but not the sections). It appears to be a focus issue, as it fixes itself if I press twice the down arrow key to focus the view again. This doesn’t happen with e.g. the settings view.

As pointed out in an earlier comment, in debian/control, the build dependency and runtime dependency of webbrowser-app on qtdeclarative5-ubuntu-ui-toolkit-plugin need to specify that they require a version >= 1.3.

When running the autopilot tests on my vivid desktop with version 1.3 of the toolkit, I need to modify line 295 of tests/autopilot/webbrowser_app/emulators/browser.py to make the tests pass: s/Icon11/Icon/. I was told by Brendan earlier today that this is a recent change in autopilot, can you apply it in this branch and verify that CI is happy with it?

Even with the above fixed, I’m seeing 3 errors when running the autopilot tests for test_new_tab_view on my desktop:
  webbrowser_app.tests.test_new_tab_view.TestNewTabViewContents.test_open_top_site
  webbrowser_app.tests.test_new_tab_view.TestNewTabViewContents.test_default_home_bookmark
  webbrowser_app.tests.test_new_tab_view.TestNewTabViewContents.test_open_bookmark