Code review comment for lp:~uriboni/webbrowser-app/new-tab-wide-format
Revision history for this message
| Ugo Riboni (uriboni) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
7020100
(Get the code!)
All other items that are not specifically mentioned here should have been fixed or addressed.
> Why is there a new "selectedIndexN
> this is because the UX spec mandates that the state being retained, then it
> shouldn’t be a setting. Instead, the StateSaver should be used for that.
It needs a setting because the StateSaver won't save the state when closing the app normally, and we want to remember in which section to open the view by default regardless of how the app was closed.
> The spec doesn’t consider the case where a bookmark folder is empty. Can you
> check with design whether we should display some sort of informative message
> in this case, or if having an empty right panel is expected?
I had already asked some days ago. They are working on it AFAIK.