Code review comment for lp:~uriboni/webbrowser-app/media-access

Revision history for this message
Olivier Tilloy (osomon) wrote :

There’s still one remaining trailing semi-colon in JS code (in Browser.qml).

The import of "../UrlUtils.js" in MediaAccessDialog.qml is unused. So is "id: dialog".

In MediaAccessDialog.qml, the comment for translators could be more specific (e.g. "requesting access *to the microphone/camera*"). Keep in mind that translators are not expected to go read the code to figure out the context of a string.

In SettingsDeviceSelector.qml, shouldn’t updateDefaultDevice() be called when isAudio changes, too?

review: Needs Fixing

« Back to merge proposal