Code review comment for lp:~uriboni/webbrowser-app/find-in-page

I am not convinced the change to src/Ubuntu/Web/UbuntuWebView02.qml is needed (I don’t see why it should be, and reverting it doesn’t seem to break the functionality, at least when run locally on my desktop). There’s nothing in the UbuntuWebView component that requires oxide 1.8, it’s only the browser that makes use of it that requires access to the findController API. The import statement in AddressBar.qml should probably be bumped though. Even though not strictly needed for the code to be parsed and interpreted by the QML engine, it’s assuming the findController object is there.

When launching the app locally I’m seeing the following message printed twice before anything else in the console:

    QString::arg: Argument missing: "" , 0

Could you look into what’s causing it to be printed?