unity-2d

Code review comment for lp:~uriboni/unity-2d/launcher-shortcuts-on-hold-dash-on-tap

  1. launcher-shortcuts-on-hold-dash-on-tap
  2. Merge into natty
Revision history for this message
Olivier Tilloy (osomon) wrote :

Having two attributes for the state of the super key, m_superKeyPressed and m_superKeyHeld, is rather confusing, even if m_superKeyPressed is private. I would expect 'held' to imply 'press'.
If I read the code correctly, the only place where m_superKeyPressed is used is in LauncherView::updateSuperKeyHoldState(). Can’t you get rid of the attribute and test the state of the modifier using KeyboardModifiersMonitor::keyboardModifiers()?

« Back to merge proposal