Code review comment for lp:~uriboni/unity-2d/clean-up-dash-dbus

Revision history for this message
Olivier Tilloy (osomon) wrote :

Packages fail to build from source with the following error:

Building CXX object places/app/CMakeFiles/unity-2d-places.dir/dashdeclarativeview.cpp.o
cd /home/osomon/dev/unity-2d/build-area/unity-2d-3.6.1/obj-x86_64-linux-gnu/places/app && /usr/bin/g++ -g -O2 -g -Wall -O2 -Woverloaded-virtual -Wall -std=c++0x -I/home/osomon/dev/unity-2d/build-area/unity-2d-3.6.1/obj-x86_64-linux-gnu -I/usr/include/qt4 -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtDBus -I/usr/include/qt4/QtDeclarative -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtGui -I/home/osomon/dev/unity-2d/build-area/unity-2d-3.6.1/obj-x86_64-linux-gnu/places/app -I/usr/include/QtGConf -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/home/osomon/dev/unity-2d/build-area/unity-2d-3.6.1/libunity-2d-private/src -o CMakeFiles/unity-2d-places.dir/dashdeclarativeview.cpp.o -c /home/osomon/dev/unity-2d/build-area/unity-2d-3.6.1/places/app/dashdeclarativeview.cpp

In file included from /home/osomon/dev/unity-2d/build-area/unity-2d-3.6.1/places/app/dashdeclarativeview.cpp:18:
/home/osomon/dev/unity-2d/build-area/unity-2d-3.6.1/obj-x86_64-linux-gnu/places/app/dashadaptor.h:17: fatal error: dashdeclarativeview.h: No such file or directory

review: Needs Fixing

« Back to merge proposal