unity-2d

Code review comment for lp:~uriboni/unity-2d/clean-up-dash-dbus

  1. clean-up-dash-dbus
  2. Merge into natty
Revision history for this message
Olivier Tilloy (osomon) wrote :

In places/app/dash.xml:

+ <method name="activatePlaceEntry">
+ <dox:d>Activates the Dash and shows the specified Place</dox:d>

Should be "[…] shows the specified place entry".

+ <signal name="activePlaceEntryChanged">
+ <dox:d>Signals when the currently active place in the Dash changes</dox:d>

Same here, and everywhere else really: "place" ≠ "place entry". Please make sure that the terminology is consistent.

review: Needs Fixing

« Back to merge proposal