Code review comment for lp:~uriboni/unity-2d/clean-up-dash-dbus

Revision history for this message
Olivier Tilloy (osomon) wrote :

You need to update the other components to activate the service on the new, normalized interface name:

$ grep -rn "\"com.canonical.Unity2d\"" *
launcher/UnityApplications/placeentry.cpp:146:static const char* DASH_DBUS_SERVICE = "com.canonical.Unity2d";
launcher/app/gesturehandler.cpp:120: QDBusInterface dashInterface("com.canonical.Unity2d", "/Dash", "com.canonical.Unity2d.Dash");
panel/applets/homebutton/homebuttonapplet.cpp:34:static const char* DBUS_SERVICE = "com.canonical.Unity2d";

review: Needs Fixing (code)

« Back to merge proposal