Merge lp:~uriboni/camera-app/shutter-sound-settings into lp:camera-app

Proposed by Ugo Riboni
Status: Superseded
Proposed branch: lp:~uriboni/camera-app/shutter-sound-settings
Merge into: lp:camera-app
Diff against target: 63 lines (+26/-2)
2 files modified
OptionButton.qml (+1/-1)
ViewFinderOverlay.qml (+25/-1)
To merge this branch: bzr merge lp:~uriboni/camera-app/shutter-sound-settings
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Pending
Ubuntu Phablet Team Pending
Review via email: mp+278438@code.launchpad.net

This proposal has been superseded by a proposal from 2015-11-25.

Commit message

Add option to disable shutter sound

Description of the change

Add option to disable shutter sound.

Requires lp:~uriboni/qtubuntu-camera/shutter-sound-settings for the setting to actually take effect.

To post a comment you must log in.
607. By Ugo Riboni

Fix OptionButton so that toggles can also have icons

608. By Ugo Riboni

Make shutter sound a toggle and display it only when taking still pictures

609. By Ugo Riboni

Fix mistake

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'OptionButton.qml'
--- OptionButton.qml 2015-10-22 12:21:14 +0000
+++ OptionButton.qml 2015-11-24 16:18:26 +0000
@@ -23,7 +23,7 @@
23 property var model23 property var model
24 property string settingsProperty: model.settingsProperty24 property string settingsProperty: model.settingsProperty
2525
26 iconName: model.isToggle || !model.get(model.selectedIndex).icon ? model.icon : model.get(model.selectedIndex).icon26 iconName: !model.get(model.selectedIndex).icon ? model.icon : model.get(model.selectedIndex).icon
27 iconSource: (model && model.iconSource) ? model.iconSource : ""27 iconSource: (model && model.iconSource) ? model.iconSource : ""
28 on: model.isToggle ? model.get(model.selectedIndex).value : true28 on: model.isToggle ? model.get(model.selectedIndex).value : true
29 enabled: model.available29 enabled: model.available
3030
=== modified file 'ViewFinderOverlay.qml'
--- ViewFinderOverlay.qml 2015-10-22 12:21:14 +0000
+++ ViewFinderOverlay.qml 2015-11-24 16:18:26 +0000
@@ -50,6 +50,7 @@
50 property bool gridEnabled: false50 property bool gridEnabled: false
51 property bool preferRemovableStorage: false51 property bool preferRemovableStorage: false
52 property string videoResolution: "1920x1080"52 property string videoResolution: "1920x1080"
53 property bool playShutterSound: true
5354
54 onFlashModeChanged: if (flashMode != Camera.FlashOff) hdrEnabled = false;55 onFlashModeChanged: if (flashMode != Camera.FlashOff) hdrEnabled = false;
55 onHdrEnabledChanged: if (hdrEnabled) flashMode = Camera.FlashOff56 onHdrEnabledChanged: if (hdrEnabled) flashMode = Camera.FlashOff
@@ -404,6 +405,29 @@
404 property bool available: true405 property bool available: true
405 property bool visible: camera.captureMode == Camera.CaptureVideo406 property bool visible: camera.captureMode == Camera.CaptureVideo
406 property bool showInIndicators: false407 property bool showInIndicators: false
408 },
409 ListModel {
410 id: shutterSoundOptionsModel
411
412 property string settingsProperty: "playShutterSound"
413 property string icon: ""
414 property string label: ""
415 property bool isToggle: true
416 property int selectedIndex: bottomEdge.indexForValue(shutterSoundOptionsModel, settings.playShutterSound)
417 property bool available: true
418 property bool visible: camera.captureMode === Camera.CaptureStillImage
419 property bool showInIndicators: false
420
421 ListElement {
422 icon: "audio-volume-high"
423 label: QT_TR_NOOP("On")
424 value: true
425 }
426 ListElement {
427 icon: "audio-volume-muted"
428 label: QT_TR_NOOP("Off")
429 value: false
430 }
407 }431 }
408 ]432 ]
409433
@@ -582,7 +606,7 @@
582 id: shootingTimer606 id: shootingTimer
583 repeat: true607 repeat: true
584 triggeredOnStart: true608 triggeredOnStart: true
585 609
586 property int remainingSecs: 0610 property int remainingSecs: 0
587611
588 onTriggered: {612 onTriggered: {

Subscribers

People subscribed via source and target branches