Code review comment for lp:~urbanape/bindwood/work-with-folders

Revision history for this message
Zachery Bir (urbanape) wrote :

Summary: Handle bookmarks per-profile, sync sub-folders, and
provide additional views in Couch.

  Branches represented in this merge proposal
  ===========================================

  deleted-view:

    Provide a deleted objects view, so when all client machines
    have synced deletions, the owner can purge them from Couch.

    Also, filter them out of the regular view.

  handle-all-profiles:

    Properly sync whichever profile is currently being used.

    We tag each bookmark as belonging to the current profile, and
    we use the current profile as a filter when pulling
    bookmarks.

    To test, you'll need this Bindwood branch installed on at
    least two profiles. If you need a second profile, you can run
    the Profile Manager from the command line:

      $ firefox --profilemanager

    Re-create the <email address hidden> extension file in
    ~/.mozilla/firefox/<new profile directory>/extensions/ with
    the following contents (note no trailing slash):

      /path/to/bindwood/checkout

    If you start up Firefox using your new profile:

      $ firefox -P newprofilename &

    And navigate to your CouchDB, you should see the combined
    bookmarks of all profiles. However, if you look at any
    individual bookmark, in its `application_annotations` object,
    you'll see it tied to a specific profile. Similarly, Bindwood
    will only pull that profile's bookmarks, so no cross-profile
    pollution should happen.

  work-with-folders:

    This branch ensures that all bookmarks are synced. Previous
    branches only dealt with immediate children of the three main
    bookmark folders: toolbarFolder, bookmarksMenuFolder, and
    unfiledBookmarksFolder. This branch recursively descends into
    any subfolders located here, syncing any bookmarks it finds.

    To test, create a profile without Bindwood installed, and
    create arbitrarily nested folders in any of these bookmark
    folders. When Bindwood is enabled, you should see all
    bookmarks throughout the hierarchy represented in
    Couch. Previous versions of Bindwood would only sync the
    immediate child bookmarks of the top folder.

Testing strategies
==================

  * If you have any deleted bookmarks, you'll be able to select
    the 'deleted' view in Couch to see them, separate from your
    live bookmarks.

  * If you use multiple profiles, you'll be able to sync each of
    them, without collisions between profiles. There are
    additional views registered for each profile that will show
    you only the bookmarks per profile.

  * If you have sub-folders of any of the three main
    folders (toolbarFolder, bookmarksMenuFolder, and
    unfiledBookmarksFolder), those will also be synced to Couch.

« Back to merge proposal