Code review comment for lp:~unity-team/unity8/two_see_more_bugfix

Revision history for this message
Albert Astals Cid (aacid) wrote :

> A question more for the backend: is it possible to have same categoryId? (in
> case someone badly implements a scope) We are checking for the id string now,
> rather the obj

Yes, we used to check for id not too long ago, but was [wrongly] changed in r1212 http://bazaar.launchpad.net/~unity-team/unity8/trunk/revision/1212

I say wrognly changed because keeping the pointer to the delegate means that if you scroll a lot in the list and the delegate gets destroyed, when you come back it'll be a different delegate pointer.

« Back to merge proposal