Code review comment for lp:~unity-team/unity8/sessionIndicatorForDevices
Revision history for this message
| Michael Terry (mterry) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Well it works. But I've got some beefs:
- "About This Device" should probably be just "About", following System Settings' lead.
- The dialog we show on shut down is oddly different than the normal shutdown. We should use the same button sorting (Shut down on top) and labels (Restart instead of Reboot). And the menu and dialog use "Shut down" when the normal dialog uses "Power off".
We could just use the same dialog. But we'd still have to fix the menu. Has design had a chance to comment on any of this?
- The long standing bug about duplicate separator items really stands out here and makes the menu look bad... Is that an easy fix? /me looks into it real quick