Code review comment for lp:~unity-team/unity8/sessionIndicatorForDevices

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

> Huh... org.freedesktop.DisplayManager does not seem to emit a signal when we ask it to lock... I > guess the intention was for lightdm to switch VTs. And then the desktop session would notice
> the vt switch? I'd have to check how we know to lock the session in such cases.

> But I guess this is OK for now. We might have to confirm everything works as expected here in the > split greeter branches though.

Yup, I guess in the long term, this signal should be emitted

> + if ((new_indicator->identifier() == QStringLiteral("indicator-session"))

> Can we not just drop that check and enable the correct profile for indicator-session? Does it
> still not have profile support? It would be more correct to fix that in the indicator than
> patch its menu items in unity8...

Yeah, no proper "phone" profile and certainly no time to do it now :/

« Back to merge proposal