Merge lp:~unity-team/unity8/new-scopes-vj-integration into lp:~unity-team/unity8/new-scopes
Proposed by
Albert Astals Cid
Status: | Rejected |
---|---|
Rejected by: | Albert Astals Cid |
Proposed branch: | lp:~unity-team/unity8/new-scopes-vj-integration |
Merge into: | lp:~unity-team/unity8/new-scopes |
Diff against target: |
381 lines (+337/-1) 5 files modified
qml/Components/ResponsiveVerticalJournal.qml (+68/-0) qml/Dash/CardVerticalJournal.qml (+60/-0) qml/Dash/GenericScopeView.qml (+2/-1) tests/qmltests/CMakeLists.txt (+1/-0) tests/qmltests/Components/tst_ResponsiveVerticalJournal.qml (+206/-0) |
To merge this branch: | bzr merge lp:~unity-team/unity8/new-scopes-vj-integration |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Albert Astals Cid (community) | Needs Fixing | ||
Michał Sawicz | Pending | ||
Review via email: mp+214786@code.launchpad.net |
This proposal supersedes a proposal from 2014-01-16.
Description of the change
Add VerticalJournal integration.
To post a comment you must log in.
Unmerged revisions
- 590. By Michał Karnicki
-
Expand CardVerticalJournal to fill its parent.
- 589. By Michał Karnicki
-
Add bottom margin.
- 588. By Michał Karnicki
-
Fetch template and components from DashRenderer. Set RVJ columnWidth cased on card size from template.
- 587. By Michał Karnicki
-
Bind ResponsiveVJ model and height.
- 586. By Michał Karnicki
-
Update CardVerticalJournal defaults.
- 585. By Michał Karnicki
-
Make column count dynamic.
- 584. By Michał Karnicki
-
Fix copyright headers.
- 583. By Michał Karnicki
-
Don't try to fix the header title positioning with hardcorded value.
- 582. By Michał Karnicki
-
Fix column and row spacing tests.
- 581. By Michał Karnicki
-
Add ResponsiveVerti
calJournal tests. column and row spacing still not passing.
PS the abstractjournal.cpp and verticaljournal.cpp changes come from Albert, and have been merged in a different branch already. I added them to avoid crashers.